tracer: support request in cel sampler#38617
Merged
wbpcode merged 4 commits intoenvoyproxy:mainfrom Mar 12, 2025
Merged
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
wbpcode
reviewed
Mar 5, 2025
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Some minor comments are added.
source/extensions/tracers/opentelemetry/samplers/cel/cel_sampler.cc
Outdated
Show resolved
Hide resolved
source/extensions/tracers/opentelemetry/samplers/cel/cel_sampler.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: zirain <zirain2009@gmail.com>
yanavlasov
reviewed
Mar 11, 2025
Contributor
yanavlasov
left a comment
yanavlasov
left a comment
There was a problem hiding this comment.
LGTM. Will wait for @wbpcode approval.
/wait-any
wbpcode
approved these changes
Mar 12, 2025
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
<!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) --> Commit Message: this's a follow up for envoyproxy#38182, make `request` work on cel sampler, cc @wbpcode Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: zirain <zirain2009@gmail.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
<!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) --> Commit Message: this's a follow up for envoyproxy#38182, make `request` work on cel sampler, cc @wbpcode Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: zirain <zirain2009@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: this's a follow up for #38182, make
requestwork on cel sampler, cc @wbpcodeAdditional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]